-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[WIP]style(beta): use logical properties #613
base: main
Are you sure you want to change the base?
Conversation
Demo will be published at https://apps.inindca.com/common-ui-docs/genesys-webcomponents/feature/COMUI-3096 |
I would have expected to see a change here and then running the linter sort out the actual scss files |
23d2ede
to
aa42c18
Compare
Some issues here with popovers and the toggle. Looking into them. |
b87eab0
to
e2fb50f
Compare
...s-spark-components/src/components/stable/gux-toggle/gux-toggle-slider/gux-toggle-slider.scss
Outdated
Show resolved
Hide resolved
// TODO: Use :dir() selector instead when Chrome improves support for it | ||
const compStyles = window.getComputedStyle(this.checkboxElement); | ||
this.direction = compStyles.direction; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
flagging manual changes in this file
e0c88c1
to
d04cd27
Compare
"plugins": ["stylelint-use-logical-spec"], | ||
"rules": { | ||
"liberty/use-logical-spec": true | ||
} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looking at this PR again I think we should do this in a few PRs over a few weeks to reduce the risk. We are also not going to want to change the legacy components at all so we will need to have an override for that.
See can you find a config that changes about 40 files. Also have the example.html files changes in their own PR as they are not that critical.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Was thinking it might be good to start with beta components and go from there.
✅ Closes: COMUI-3096
d04cd27
to
c4d2c07
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I took a look at the beta components in different browsers and I did not see any regressions.
I tested all the components that this PR touched and I also did not see any regressions. |
This is just kind of a POC for now until I get a bit of testing done with a native user of rtl. Don't panic when you see all the additions.
✅ Closes: COMUI-3096